[Webkit-unassigned] [Bug 221734] New: REGRESSION (r232410): WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirectory needs to be exported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221734

            Bug ID: 221734
           Summary: REGRESSION (r232410):
                    WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirector
                    y needs to be exported
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: cdumez at apple.com, katherine_cheney at apple.com,
                    sihui_liu at apple.com

WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirectory() in Source/WebCore/platform/sql/SQLiteFileSystem.h needs to be marked as WEBCORE_EXPORT so that it can be used in WebKit::LocalStorageDatabaseTracker::deleteAllDatabases() from Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp in WebKit.framework.

This probably hasn't been found before since WebKit.framework has dead code stripping unconditionally enabled via Source/WebKit/Configurations/Base.xcconfig:

// Dead code stripping needs to be on in the debug variant to avoid link errors.  This is due to unconditionally
// building the MiG bindings for WebKitPluginClient even when the functions that the bindings wrap are not built.
DEAD_CODE_STRIPPING = YES;

Most other WebKit projects disable dead code stripping in Debug builds like this:

DEAD_CODE_STRIPPING = YES;
DEAD_CODE_STRIPPING[config=Debug] = NO;

I guess this also means that LocalStorageDatabaseTracker::deleteAllDatabases() is dead code.

Maybe we can just delete LocalStorageDatabaseTracker::deleteAllDatabases() instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210211/23147641/attachment.htm>