[Webkit-unassigned] [Bug 221676] Returning sRGB from CG color space functions on failure is too error prone

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221676

--- Comment #4 from Sam Weinig <sam at webkit.org> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 419849 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419849&action=review
> 
> > Source/WebCore/platform/graphics/cg/ColorSpaceCG.h:120
> > +// NOTE: This function is guarenteed to return non-null, unlike cachedNullableCGColorSpace().
> 
> Seems mysterious to not say *why* it’s guaranteed. The subtle difference
> between DestinationColorSpace and ColorSpace. I’d say something like, "Since
> this is for *destination* color spaces, this function is ..."
> 
> Also, the word guaranteed is misspelled!

The only thing guaranteed in this world is that I will misspell "guaranteed".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210211/2a4b7e9d/attachment-0001.htm>