[Webkit-unassigned] [Bug 220979] Complete XRSession::requestAnimationFrame implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220979

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #419713|review?                     |review+
              Flags|                            |

--- Comment #24 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 419713
  --> https://bugs.webkit.org/attachment.cgi?id=419713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419713&action=review

> Source/WebCore/Modules/webxr/WebXRSession.cpp:505
> +            auto callbacks = m_callbacks;

Can we do:
auto callbacks = WTFMove(m_callbacks).

> Source/WebCore/Modules/webxr/WebXRSession.cpp:508
> +            frame->setActive(true);

We went from a model where we were reusing the same frame over and over to creating a new frame each time.
This is observable from JS so we should add a test for it.
And verify other browsers are doing the same.

> Source/WebCore/Modules/webxr/WebXRSession.cpp:527
> +            });

Not needed if we can clear m_callbacks above.

> Source/WebCore/Modules/webxr/WebXRSystem.h:118
> +        ScriptExecutionContext* m_scriptExecutionContext { nullptr };

This is probably incorrect. Let's make it a ContextDesutrctionObserver.

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:205
> +    return WTF::switchOn(m_context, [](const RefPtr<WebGLRenderingContextBase>& baseContext) {

What about #if ENABLE(WEBGL2)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210210/06fa6fae/attachment-0001.htm>