[Webkit-unassigned] [Bug 221618] Drop pixel test support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221618

Sam Sneddon [:gsnedders] <gsnedders at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmaxfield at apple.com,
                   |                            |zalan at apple.com

--- Comment #3 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #1)
> I think I'm OK with removing expected.png files, but I'm hesitant about
> removing support for run-webkit-tests --pixel, because there might be times
> where a developer wants to do before/after pixel testing of a change by
> rebasing pixel results first, then running tests.

FWIW, I have some concern about our ability to keep all that code working when it isn't running on any bot, hence I somewhat question the value of keeping it around if we're never actually running it. There's enough scattered around various parts of the codebase it feels somewhat fragile.

If we _do_ want to keep it, I'd rather we started running at the very least a small number of pixel tests in CI. (Though I don't much like the idea of running them at all, given how fragile they are!)

(In reply to Alexey Proskuryakov from comment #2)
> What's been stopping us before was that even though pixel tests couldn't
> meaningfully run, referring to an ancient -expected.png file provided
> insight into what a test was meant to do.

My proposal here was to just remove the support from run-webkit-tests, and not necessarily do anything about the -expected.png files (which IIRC Myles saw value in, for the reason you say).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210210/c05cdb3a/attachment-0001.htm>