[Webkit-unassigned] [Bug 221511] [LayoutTests] Convert http/tests/css convert PHP to Python

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221511

--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 419782
  --> https://bugs.webkit.org/attachment.cgi?id=419782
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419782&action=review

> LayoutTests/http/tests/css/resources/500.py:9
> +    'HTTP/1.0 500 Internal Error\r\n'

Shouldn't this just be: 'status: 500\r\n'?

> LayoutTests/http/tests/css/resources/webfont-request.py:21
> +sys.path.insert(0, http_root)

Does not look like we actually need this, since you aren't using any shared code

> LayoutTests/http/tests/css/resources/webfont-request.py:37
> +        'Content-Type: application/octet-stream\r\n\r\n'

"echo" results in a newline, so we should add a \n to this string

> LayoutTests/http/tests/css/resources/webfont-request.py:44
> +        '{}'.format(currentCount)

"echo" results in a newline, so we should add a \n to this string

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210210/b6328597/attachment-0001.htm>