[Webkit-unassigned] [Bug 221267] WebXRSystem::RequestSession with 'viewer' as a required feature should succeed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221267

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |svillar at igalia.com
 Attachment #419017|review?                     |review+
              Flags|                            |

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 419017
  --> https://bugs.webkit.org/attachment.cgi?id=419017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419017&action=review

> Source/WebCore/Modules/webxr/WebXRSystem.cpp:211
> +            auto feature = parseEnumeration<XRReferenceSpaceType>(*globalObject.document()->globalObject(), features.first());

I guess you can directly use the document parameter instead of retrieving it from the DOMWindow.

> LayoutTests/ChangeLog:8
> +        * platform/wpe/TestExpectations:

Nit: just add something like "marked a test as passing" or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210208/6d49ac03/attachment.htm>