[Webkit-unassigned] [Bug 221543] [SOUP] Simplify ResourceRequest and ResourceResponse

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221543

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #419573|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 419573
  --> https://bugs.webkit.org/attachment.cgi?id=419573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419573&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:63
> +    GRefPtr<SoupMessage> soupMessage = adoptGRef(soup_message_new_from_uri(httpMethod().ascii().data(), uri.get()));

I would have used “auto” here because the “adoptGRef()” + “soup_message_new_foo()”
calls already make it quite clear that the inferred type will be “GRefPtr<SoupMessage>”
No strong preference, though.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-174
> -

Nice to see some code go away \o/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210208/5d3c257e/attachment.htm>