[Webkit-unassigned] [Bug 221406] Some privateClickMeasurement might output the information in different order depending on platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221406

katherine_cheney at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katherine_cheney at apple.com

--- Comment #2 from katherine_cheney at apple.com ---
Comment on attachment 419283
  --> https://bugs.webkit.org/attachment.cgi?id=419283
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419283&action=review

> LayoutTests/ChangeLog:8
> +        The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be

nit: header's order

> LayoutTests/http/tests/privateClickMeasurement/resources/conversionReport.php:8
> +if (array_key_exists("HTTP_HOST", $httpHeaders)) {

Could you do something like “if ($value = $httpHeaders[“HTTP_HOST”]) or will that not work in php? It would turn 2 lines into 1, and only require one lookup. Ditto for all the rest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210204/1d4296fe/attachment.htm>