[Webkit-unassigned] [Bug 221344] New: Optimize AnimationTimeline::elementWasRemoved()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221344

            Bug ID: 221344
           Summary: Optimize AnimationTimeline::elementWasRemoved()
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Animations
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: dino at apple.com, graouts at apple.com

AnimationTimeline::elementWasRemoved() shows up as hot in Speedometer since Element::removedFromAncestor() is called a lot. I see removals with both idle and active animations (color transitions).

      WebCore::Element::removedFromAncestor(WebCore::Node::RemovalType, WebCore::ContainerNode&)
       WebCore::AnimationTimeline::elementWasRemoved(WebCore::Styleable const&)
        WebCore::DeclarativeAnimation::cancel(WebCore::WebAnimation::Silently)
         WebCore::WebAnimation::cancel(WebCore::WebAnimation::Silently)
         WebCore::AnimationEffect::getBasicTiming(WTF::Optional<WTF::Seconds>) const
          WebCore::AnimationEffect::getBasicTiming(WTF::Optional<WTF::Seconds>) const::$_0::operator()() const
           WebCore::WebAnimation::currentTime(WTF::Optional<WTF::Seconds>) const
            WebCore::WebAnimation::currentTime(WebCore::WebAnimation::RespectHoldTime, WTF::Optional<WTF::Seconds>) const
            WebCore::DocumentTimeline::currentTime()
         WTF::fastMalloc(unsigned long)
          bmalloc::api::malloc(unsigned long, bmalloc::HeapKind)
           bmalloc::Cache::allocate(bmalloc::HeapKind, unsigned long)
         WebCore::WebAnimation::effect() const
        WebCore::DeclarativeAnimation::invalidateDOMEvents(WTF::Seconds)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210203/b49725d7/attachment.htm>