[Webkit-unassigned] [Bug 221097] Null dereference in DocumentLoader::commitData()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221097

--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Julian Gonzalez from comment #11)
> (In reply to Julian Gonzalez from comment #9)
> > (In reply to Darin Adler from comment #8)
> > > (In reply to Julian Gonzalez from comment #7)
> > > > Trying to include
> > > > "MediaDocument.h" or <WebCore/MediaDocument.h> however, doesn't work from
> > > > this file. Any suggestions?
> > > 
> > > Including <WebCore/MediaDocument.h> is the right thing to do. If it doesn’t
> > > work in Cocoa builds, then presumably we just need to change MediaDocument.h
> > > to be exposed from WebCore to WebKit, which is easiest to do on a Mac. Need
> > > to change the header’s visibility from "project" to "private".
> > 
> > Thanks, that worked!
> 
> Well, not quite:
> 
> In file included from
> DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-30.cpp:2:
> ../../Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:80:10:
> fatal error: WebCore/MediaDocument.h: No such file or directory
>    80 | #include <WebCore/MediaDocument.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> GTK, WPE, WinCairo fail to build.
> Is there another list I also have to change?

Oh, we probably need to export that file. Add it to Source/WebCore/Headers.cmake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210203/69b55d00/attachment.htm>