[Webkit-unassigned] [Bug 221140] [LayoutTests] Convert http/tests/inspector/ convert PHP to Python

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221140

--- Comment #16 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 419045
  --> https://bugs.webkit.org/attachment.cgi?id=419045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419045&action=review

Before we land this change, we need to ensure all ports are ok with the change and ensure that this works on our Windows ports.

> LayoutTests/http/tests/inspector/network/resources/basic-auth.py:9
> +expectedUsername = "goodUsername"

Lets standardize on single quotes

> LayoutTests/http/tests/inspector/network/resources/delay.py:16
> +time.sleep((delay * 1000) * 0.000001)

This should just be time.sleep(delay / 1000)

> LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:21
> +ct = os.environ.get('CONTENT_TYPE')

Let's use a better variable than 'ct', perhaps 'content_type'?

> LayoutTests/http/tests/inspector/network/resources/intercept-echo.py:31
> +sys.stdout.write('    \"uri\": \"{}\",\n'.format(os.environ.get('REQUEST_URI')))

We shouldn't need to escape the "s in this string, since this string is using single quotes

> LayoutTests/http/tests/inspector/network/resources/json.py:7
> +sys.stdout.write('{\"version\": 1}')

We shouldn't need to escape the "s in this string, since this string is using single quotes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210202/102be25f/attachment.htm>