[Webkit-unassigned] [Bug 221206] [SOUP] Stop using SoupBuffer in preparation for libsoup3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221206

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #4)
> Comment on attachment 418874 [details]
> Patch
> 
> LGTM as well
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418874&action=review
> 
> >> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69
> >> +        SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr),
> > 
> > auto* soupBuffer ?
> > 
> > Also I guess this would be migrated later right? Consider adding a comment.
> 
> I assume that there will be later a patch adding the support to actually
> use libsoup3 inside “#if SOUP_CHECK_VERSION(2, 91, 0)” guards (or similar)
> and
> this version of the code will be in the “#else” arm of the conditional =]

Exactly, it will be kept in the libsoup2 branch

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210202/43568512/attachment.htm>