[Webkit-unassigned] [Bug 221186] Detect unrecognized options in run-javascriptcore-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221186

--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 418825
  --> https://bugs.webkit.org/attachment.cgi?id=418825
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418825&action=review

> Tools/ChangeLog:12
> +        through to build-jsc even when --no-build is used. However, when
> +        we're not building nothing will ever use or look at the extra
> +        arguments, which means that those arguments are silently eaten
> +        up. This means that typos in option names can go undetected.

Seems like a run-on sentence. Maybe it would be clearer as: 

However, when we're not building, nothing will ever use or look at the extra arguments. This means that those arguments are silently eaten up.

> Tools/Scripts/run-javascriptcore-tests:490
> +    # Assume any arguments left over from GetOptions are assumed to be build arguments

Seems like there's an existing typo. Can you change this to:

Assume any arguments left over from GetOptions are to be passed as build arguments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210201/2591a240/attachment-0001.htm>