[Webkit-unassigned] [Bug 220979] Complete XRSession::requestAnimationFrame implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220979

--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 418423
  --> https://bugs.webkit.org/attachment.cgi?id=418423
Add co-authors to the changelog messages

View in context: https://bugs.webkit.org/attachment.cgi?id=418423&action=review

>>> Source/WebCore/Modules/webxr/WebXRFrame.h:63
>>> +    bool m_animationFrame;
>> 
>> `m_animationFrame` is set but never used. This can trigger an unused private field warning.
> 
> It actually is, see below
> 
> if (m_callbacks.size() == 1 && !m_animationFrame->isActive())

Ah sorry, I replied without checking the context. You're right.

BTW a bool should not be called like this, better use something like the parameter m_isAnimationFrame.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210201/7c7a3505/attachment-0001.htm>