[Webkit-unassigned] [Bug 234657] New: RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234657

            Bug ID: 234657
           Summary: RemoteInspectorProtocolHandler::inspect() expects
                    ConnectionID as uint32_t
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Yousuke.Kimoto at sony.com
                CC: inspector-bugzilla-changes at group.apple.com

https://bugs.webkit.org/show_bug.cgi?id=197243 fixed connection and target identifier types.

ConnectionID is 
  using ConnectionID = uint32_t;

But currently connectionID is given to RemoteInspectorProtocolHandler::inspect() as "int" by the commit https://github.com/WebKit/WebKit/commit/695e0888fe0472f49fdc27da5f57d0f5e4353e51

  m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]);

It should be "uint32_t".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211224/4766adbc/attachment-0001.htm>