[Webkit-unassigned] [Bug 234543] Archived subresource loads fail if m_allowedNetworkHosts doesn't include the remote URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 16:37:59 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=234543

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #447837|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 447837
  --> https://bugs.webkit.org/attachment.cgi?id=447837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447837&action=review

nicer

> Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm:259
> +    NSData *data = [NSPropertyListSerialization dataFromPropertyList:archive format:NSPropertyListBinaryFormat_v1_0 errorDescription:nil];

This is all duplicate code with the test before it.  Could we instead share it and make a static function that returns an NSData?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211223/406f5bbb/attachment-0001.htm>


More information about the webkit-unassigned mailing list