[Webkit-unassigned] [Bug 234387] [JSC][ARMv7] Minor code size improvements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 20 01:42:44 PST 2021
https://bugs.webkit.org/show_bug.cgi?id=234387
Geza Lore <glore at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #447344| |review?
Flags| |
--- Comment #6 from Geza Lore <glore at igalia.com> ---
Comment on attachment 447344
--> https://bugs.webkit.org/attachment.cgi?id=447344
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447344&action=review
Thanks these are very helpful. Fixed all.
>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2263
>> + m_jit.storeValue(value.jsValueRegs(), JITCompiler::addressFor(node->machineLocal()));
>
> First define JSValueRegs valueRegs = value.jsValueRegs();
Not sure this is necessary, most other cases don't do this.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211220/8389d2b8/attachment-0001.htm>
More information about the webkit-unassigned
mailing list