[Webkit-unassigned] [Bug 214870] [WPE][Pointer Events] Add support for touch based pointer events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214870

--- Comment #7 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
I was puzzled to realize that we were not running any tests for pointerevents, all of them were skipped on all platforms. So on r287196 I unskiped them and now on WPE (and GTK) we are running some of those tests.

Regarding the tests of pointerevents/ios :

 1. Those are crashing and I tested this patch and it didn't fixed them. They continue to crash

 2. I'm not sure this pointerevents/ios tests can run on other platforms than iOS. So forget my previous suggestion of renaming this to pointerevents/touch

Since those tests are skipped by default (they crash) and you want to test if your patch fixes them you have to add this line:

pointerevents/ios [ Pass ]

At the bottom of the file LayoutTests/platform/wpe/TestExpectations

And then you run the tests like this:

$ Tools/Scripts/run-webkit-tests --debug-rwt-logging --release --wpe pointerevents/ios

If your patch fixes one of those tests but not all, then you can white-list that specific test by adding a line like

pointerevents/ios/touch-action-none.html [ Pass ]


You can try to run also the tests imported from WPT by telling run-webkit-tests to run the tests from imported/w3c/web-platform-tests/pointerevents

But note that we have the bad habit of having for those imported tests expectations that contain FAIL lines. That means that if your patch fixes something there, it may appear as a failure on run-webkit-tests. You have to check the text diff and see if your patch is removing "expected failures" and adding "expected passes". If that is the case then the patch is good, you have to update the -expected.txt for that test inside the LayoutTest directory with the new -actual.txt generated. Then run-webkit-tests will stop complaining and will give the result as a pass.

If you have any doubt feel free to ask.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211217/1c2c2e9e/attachment.htm>