[Webkit-unassigned] [Bug 234116] [WebAssembly][Modules] Unify memory import handling code in both module loader and JS cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234116

--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 447328
  --> https://bugs.webkit.org/attachment.cgi?id=447328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447328&action=review

Oops, I found one issue. So commented.

> Source/JavaScriptCore/wasm/WasmModule.cpp:123
> +        RefPtr<CalleeGroup> calleeGroup;
> +        calleeGroup = m_calleeGroups[i];

Let's write it in one line. And since we never release once-created CalleeGroup, we do not need to ref here.

CalleeGroup* calleeGroup = m_calleeGroups[i].get();

> Source/JavaScriptCore/wasm/WasmModule.cpp:126
> +        if (calleeGroup && (!calleeGroup->compilationFinished() || calleeGroup->runnable()))
> +            continue;

This condition is saying, if calleeGroup exists but if it is not (!calleeGroup->compilationFinished() || calleeGroup->runnable()), then we override with the new one.
Is it right behavior? Destroying already-existing calleeGroup sounds incorrect to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211216/7c7f75dc/attachment.htm>