[Webkit-unassigned] [Bug 234155] [Shadow Realms] Use WebCore module loaders for shadow realm importValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234155

--- Comment #10 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 447147
  --> https://bugs.webkit.org/attachment.cgi?id=447147
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447147&action=review

> Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.cpp:108
> +const JSDOMGlobalObject* JSShadowRealmGlobalScopeBase::incubating() const
> +{
> +    auto incubatingWrapper = m_wrapped->m_incubatingWrapper.get();
> +    ASSERT(incubatingWrapper);
> +    return incubatingWrapper;
> +}

Why is it guaranteed that this incubatingWrapper is alive?
I think it is possible that the parent one goes away, while this JSShadowRealmGlobalObject is kept alive.
Is it correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211215/b8fd0c0f/attachment.htm>