[Webkit-unassigned] [Bug 234143] Flexbox ignores margins of absolute positioned children when `align-items: flex-end` or `justify-content: flex-end`

Wed Dec 15 01:15:43 PST 2021

https://bugs.webkit.org/show_bug.cgi?id=234143

--- Comment #13 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 447136
  --> https://bugs.webkit.org/attachment.cgi?id=447136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447136&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1692
> +    const LayoutUnit availableSpace = mainAxisContentExtent(contentLogicalHeight()) - childMainExtent;

Just use auto instead of LayoutUnit. And remove the const as we don't normally use it for variables in WebKit.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1703
> +    LayoutUnit availableSpace = crossAxisContentExtent() - childCrossExtent;

Ditto LayoutUnit->auto.

> LayoutTests/ChangeLog:12
> +        * imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003.html: Added.

You have to rebuild the ChangeLog as it's wrong.

> LayoutTests/imported/w3c/ChangeLog:13
> +        * web-platform-tests/css/css-flexbox/abspos/position-absolute-015-expected.txt:

Ditto.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003-expected.html:5
> +-->

Please remove this as the WPT project has its own license policies.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003-expected.html:7
> +<head>

No need for <html> or <head> tags.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003-expected.html:10
> +  <meta charset="utf-8">

You don't have to include all this in the expected (or -ref in WPT terminology) file.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003-expected.html:39
> +<body>

Also no need for <body>

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003.html:7
> +<head>

Ditto license & unneeded tags.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/position-absolute-014-expected.txt:3
> +PASS The bottom of each pair of boxes should be the same

This should not be needed now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211215/855d0f94/attachment.htm>