[Webkit-unassigned] [Bug 234318] New: Display list iteration should automatically stop iterating if an item is null

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 15:26:49 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=234318

            Bug ID: 234318
           Summary: Display list iteration should automatically stop
                    iterating if an item is null
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gnavamarino at apple.com

We should consider modifying DisplayList::Iterator::operator== so display list iteration automatically stops iterating if an item is null.

As was previously recommended, this can be done by making DisplayList::Iterator::operator== return true when called with a null iterator and the end iterator by changing
```
bool operator==(const Iterator& other) const { return &m_displayList == &other.m_displayList && m_cursor == other.m_cursor; }
```

to
```
bool operator==(const Iterator& other) const
{
    if (atEnd() && other.atEnd())
        return true;
    return &m_displayList == &other.m_displayList && m_cursor == other.m_cursor;
}
```

This requires updating the following two API tests:
- TestWebKitAPI.DisplayListTests.InlineItemValidationFailure
- TestWebKitAPI.DisplayListTests.OutOfLineItemDecodingFailure

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211214/9f57eaeb/attachment.htm>


More information about the webkit-unassigned mailing list