[Webkit-unassigned] [Bug 234234] Dead code in LinkIconCollector.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234234

--- Comment #3 from karl <karl+webkit at la-grange.net> ---
Alex,

> How did you find this?

I was in the process of reading the code because I had just opened 
https://bugzilla.mozilla.org/show_bug.cgi?id=1745680

And I was trying to understand how WebKit, Blink and Gecko were processing html link for icons. So I just casually reading the code when I stumbled upon this dead code. 

> can it be tested?

It can be probably tested, being my first ever patch to WebKit. I don't see any tests for compareIcons() 

The code was added 5+ years ago without tests.
https://github.com/WebKit/WebKit/commit/0148de572687b1981331e70d1135408ae8cac4f2#diff-f6e9e7480dfa766ab4c1f0b36526f8faf97018240ba256b2217236e479c43919R50-R56

If you have recommendations on where these tests should go, I can try.

> Also, we don't need to redo formatting in the change log with this.

Yes, my VSCode instance has probably reformatted the Changelog. I need to fix this. Is there a URL to a recommended vscode setup for the WebKit project. 

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211214/089f4f45/attachment.htm>