[Webkit-unassigned] [Bug 233383] AX: aria-owns in trees results duplicate rows, third level rows not being exposed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233383

--- Comment #26 from Sepand Parhami <sparhami at apple.com> ---
Comment on attachment 446606
  --> https://bugs.webkit.org/attachment.cgi?id=446606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446606&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:1902
>> +            if (result.contains(child))
> 
> we can change this to 
> 
> if (!result...) 
>    result.append(
> 
> and save a few lines

We also need to skip the `if (is<AccessibilityObject>(*child))` check below since we don't want to recurse into this subtree. Both of these continues could be pulled outside of this if, which could make this a bit clearer. This check would add a bit of extra work since it should only be relevant for treeitems and checking against other elements (e.g. groups) would never match.

I think the first check, for ariaOwns should likely be moved outside of this if (it still works if we don't, just adds extra work to fix the ordering later).

>> Source/WebCore/accessibility/AccessibilityObject.h:826
>> +    void ariaTreeRows(AccessibilityChildrenVector& result, AccessibilityChildrenVector& ancestors);
> 
> instead of result I think param could be named "rows"

Updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211213/78909c8b/attachment.htm>