[Webkit-unassigned] [Bug 234143] Flexbox ignores margins of absolute positioned children when `align-items: flex-end` or `justify-content: flex-end`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 09:12:30 PST 2021


--- Comment #9 from Sergio Villar Senin <svillar at igalia.com> ---
(In reply to Vitaly Dyachkov from comment #7)
> > First question I have is why are you changing the current ref tests with
> > checkLayout() versions? The former are generally preferred, so unless there
> > is something wrong in the current ones, I wouldn't change them. Or is it
> > because you want to test negative offsets?
> I didn't know that reftests are preferred. Instinctively I thought that API
> tests are more reliable than "comparing pixels". I'll roll back the test
> changes.

The problem with checkLayout() tests (which do not necessarily apply to your tests) is that they're pretty sensible to device/platform specifics, like for example how scrollbars or buttons are rendered (different sizes in different platforms/devices). Ref tests do not have that problem. Feel free to propose the test changes in the WPT repository if you still think they're more suitable for this case, I wouldn't oppose if some other WPT maintainer think the other way around.

Anyway in general it's better not to add changes to things that do not require those changes. It makes reviews easier and also ease the eventual process of reverting a patch causing regressions.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211213/a969df71/attachment.htm>

More information about the webkit-unassigned mailing list