[Webkit-unassigned] [Bug 234143] Flexbox ignores margins of absolute positioned children when `align-items: flex-end` or `justify-content: flex-end`

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234143

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |svillar at igalia.com

--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 446875
  --> https://bugs.webkit.org/attachment.cgi?id=446875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446875&action=review

First question I have is why are you changing the current ref tests with checkLayout() versions? The former are generally preferred, so unless there is something wrong in the current ones, I wouldn't change them. Or is it because you want to test negative offsets?

> Source/WebCore/ChangeLog:10
> +        To do that the code was correctly substructing the size of the item from the size of the container but was not substructing the margins.

Nit: substructing -> substracting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211213/31c34474/attachment-0001.htm>