[Webkit-unassigned] [Bug 234215] New: SharedBufferBuilder copy constructor should be deleted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234215

            Bug ID: 234215
           Summary: SharedBufferBuilder copy constructor should be deleted
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jean-yves.avenard at apple.com
        Depends on: 233442

Bug 233442 introduced SharedBufferBuilder ; the aim was to guarantee immutability of a SharedBuffer once created.

As such, copying a SharedBufferBuilder doesn't make much sense or it should make a copy of the underlying SharedBuffer before copying.

This paradigm isn't enforceable due to how ScriptBufferSourceProvider is using a ScriptBuffer which itself contains a SharedBufferBuilder

A ScriptBuffer is a wrapper around a SharedBuffer, designed to makes it clearer what type of data it's dealing with.

We should remove the need for copying a SharedBufferBuilder, or have ScriptBufferSourceProvider::m_scriptBuffer itself made immutable (which is prevented by ServiceWorkerGlobalScope::didSaveScriptsToDisk)


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=233442
[Bug 233442] Add SharedBufferBuilder class
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211212/3bb04db2/attachment.htm>