[Webkit-unassigned] [Bug 233906] Deployment target for macOS 11+ does not follow minor version bumps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 18:57:41 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=233906

--- Comment #24 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #22)
> > Would it be better to change our PKPaymentButtonType redeclaring to only compile below 11.0, so that we aren't overshadowing public API?
> 
> Nice catch! Not quite sure about how the latest patch implements this neat
> idea - I would expect that we need to add an include for open source builds.
> Typedefs don't shadow; we must not be including the API header now.

You're right, we aren't including it on Mac. I can play with this some more next week, but I think it's a bit out of scope for this change. My attempt to clean this up didn't help much, since we still need to include the SPI definitions for 10.15.

> Would also point out that checking iOS version is still not needed:

Thank you for the reminder, the latest patch has this fixed :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211211/1862ad4f/attachment-0001.htm>


More information about the webkit-unassigned mailing list