[Webkit-unassigned] [Bug 233906] Deployment target for macOS 11+ does not follow minor version bumps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233906

--- Comment #22 from Alexey Proskuryakov <ap at webkit.org> ---
> Would it be better to change our PKPaymentButtonType redeclaring to only compile below 11.0, so that we aren't overshadowing public API?

Nice catch! Not quite sure about how the latest patch implements this neat idea - I would expect that we need to add an include for open source builds. Typedefs don't shadow; we must not be including the API header now.

Would also point out that checking iOS version is still not needed:

> #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)
> #define HAVE_PASSKIT_NEW_BUTTON_TYPES 1
> #endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211211/4a7fed26/attachment.htm>