[Webkit-unassigned] [Bug 234138] [GPUP] Create WebGL context with task id token

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 13:34:11 PST 2021


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #446781|1                           |0
        is obsolete|                            |

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 446781
  --> https://bugs.webkit.org/attachment.cgi?id=446781

View in context: https://bugs.webkit.org/attachment.cgi?id=446781&action=review

>>> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:204
>>> +GraphicsContextGLCocoa::GraphicsContextGLCocoa(GraphicsContextGLAttributes &&creationAttributes, ProcessIdentity &&resourceOwner)
>> Why moving these "&&"? WebKit coding style calls for the way we had it already.
> Above comment

What does that comment have to do with space character placement?

I meant why are you touching this line of code at all, changing "GraphicsContextGLAttributes&& creationAttributes" to "GraphicsContextGLAttributes &&creationAttributes", which has no effect but goes against WebKit coding style?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/2a9dede6/attachment.htm>

More information about the webkit-unassigned mailing list