[Webkit-unassigned] [Bug 234138] [GPUP] Create WebGL context with task id token

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234138

--- Comment #5 from John Cunningham <johncunningham at apple.com> ---
Comment on attachment 446781
  --> https://bugs.webkit.org/attachment.cgi?id=446781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446781&action=review

>> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:367
>> +    GraphicsContextGLANGLE(GraphicsContextGLAttributes, ProcessIdentity&);
> 
> Could this be "const ProcessIdentity&"? It’s a bit unusual to pass a non-constant lvalue reference and I don’t see why we need to.

I'll change it to const. I don't believe leaving it as && would work as that would lead to a use after move bug at GraphicsContextGLCocoa.mm:215. Once the fix there is resolved, it would be good to remove this workaround and keep it as &&.

>> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:204
>> +GraphicsContextGLCocoa::GraphicsContextGLCocoa(GraphicsContextGLAttributes &&creationAttributes, ProcessIdentity &&resourceOwner)
> 
> Why moving these "&&"? WebKit coding style calls for the way we had it already.

Above comment

>> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:336
>> +    const char *displayExtensions = EGL_QueryString(m_displayObj, EGL_EXTENSIONS);
> 
> WebKit coding style calls for "const char*" or "auto".

'webkit-patch format' changes it from "const char* " to "const char *", but I'm also happy to just use auto here.

>> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:340
>> +        task_id_token_t ownerTaskIdToken = resourceOwner.taskIdToken();
> 
> Seems like we don’t need this local variable.

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/2ab4e931/attachment.htm>