[Webkit-unassigned] [Bug 234138] [GPUP] Create WebGL context with task id token
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 10 12:27:36 PST 2021
https://bugs.webkit.org/show_bug.cgi?id=234138
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |darin at apple.com
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 446781
--> https://bugs.webkit.org/attachment.cgi?id=446781
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=446781&action=review
A few coding style tweaks
> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:367
> + GraphicsContextGLANGLE(GraphicsContextGLAttributes, ProcessIdentity&);
Could this be "const ProcessIdentity&"? It’s a bit unusual to pass a non-constant lvalue reference and I don’t see why we need to.
> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:204
> +GraphicsContextGLCocoa::GraphicsContextGLCocoa(GraphicsContextGLAttributes &&creationAttributes, ProcessIdentity &&resourceOwner)
Why moving these "&&"? WebKit coding style calls for the way we had it already.
> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:336
> + const char *displayExtensions = EGL_QueryString(m_displayObj, EGL_EXTENSIONS);
WebKit coding style calls for "const char*" or "auto".
> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:340
> + task_id_token_t ownerTaskIdToken = resourceOwner.taskIdToken();
Seems like we don’t need this local variable.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/9212af10/attachment.htm>
More information about the webkit-unassigned
mailing list