[Webkit-unassigned] [Bug 233383] AX: aria-owns in trees results duplicate rows, third level rows not being exposed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 11:31:42 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=233383

--- Comment #24 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 446606
  --> https://bugs.webkit.org/attachment.cgi?id=446606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446606&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1902
> +            if (result.contains(child))

we can change this to 

if (!result...) 
   result.append(

and save a few lines

> Source/WebCore/accessibility/AccessibilityObject.h:826
> +    void ariaTreeRows(AccessibilityChildrenVector& result, AccessibilityChildrenVector& ancestors);

instead of result I think param could be named "rows"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/6930cbe4/attachment.htm>


More information about the webkit-unassigned mailing list