[Webkit-unassigned] [Bug 234155] [Shadow Realms] Use WebCore module loaders for shadow realm importValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=234155

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #446754|review?                     |review-
              Flags|                            |

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 446754
  --> https://bugs.webkit.org/attachment.cgi?id=446754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446754&action=review

Quick comment.

> Source/WebCore/page/ShadowRealmGlobalScope.h:61
> +    RefPtr<JSC::VM> m_vm;

I don't think we need to hold vm since it should be the same to the original JSGlobalObject.

> Source/WebCore/page/ShadowRealmGlobalScope.h:62
> +    JSC::Strong<JSDOMGlobalObject> m_incubatingWrapper;

It will leak JSGlobalObject if we have cycles. So, this is not OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/ee8f8d91/attachment.htm>