[Webkit-unassigned] [Bug 233941] Add support to attribute ownership of ANGLE Metal's resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233941

--- Comment #17 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 446691
  --> https://bugs.webkit.org/attachment.cgi?id=446691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446691&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp:1297
>      // clang-format on

strangely the clang-format off / on doesn't apply here?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:2450
> +GLint ContextMtl::getOwnershipIdentity(const egl::AttributeMap &attribs) const

This function should be just a compile-unit local function in the anonymous namespace at the top of the file, GetOwnershipIdentity...

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:326
> +#if HAVE(MTLRESOURCE_SET_OWNERSHIP_IDENTITY) && HAVE(TASK_IDENTITY_TOKEN)

move this to new bug and some other feedback in slack

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211210/df5819a4/attachment.htm>