[Webkit-unassigned] [Bug 225278] [css-flexbox] `gap` does not work correctly when `flex-direction: column-reverse` is applied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 04:18:35 PST 2021


--- Comment #21 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 446331
  --> https://bugs.webkit.org/attachment.cgi?id=446331

View in context: https://bugs.webkit.org/attachment.cgi?id=446331&action=review

> Source/WebCore/ChangeLog:9
> +        Take gapBetweenItems into account during RenderFlexibleBox::layoutColumnReverse.

Sorry for adding another review loop, but this should be a higher level description of the change instead of a literal description of the code change. The point is to let others not specially familiar with the code graps an idea about what the patch fixes. I'd write something like:

"Whenever flex-direction: column-reverse is specified flexbox does always compute the flex item sizes and positions ignoring the -reverse direction until the very end. After completing the computations we just need to swap offsets to get the reversed positions. The code was properly considering space between items added by content justification but it was not adding gaps. Fixed it by adding the gap size to the flex items' offsets"

Feel free to adapt it, the key is that you have to explain what the problem was and how it was fixed.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211208/8f683f2e/attachment.htm>

More information about the webkit-unassigned mailing list