[Webkit-unassigned] [Bug 225278] [css-flexbox] `gap` does not work correctly when `flex-direction: column-reverse` is applied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 00:44:31 PST 2021


--- Comment #18 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 446319
  --> https://bugs.webkit.org/attachment.cgi?id=446319

View in context: https://bugs.webkit.org/attachment.cgi?id=446319&action=review

Just fix the minor nit I mentioned and I'll give the r+. BTW as you are not committer you'd very likely should also set the cq? flag in the patch so that I could flip it to cq+ as well to get the patch landed

> Source/WebCore/ChangeLog:11
> +        Take gapBetweenItems into account during RenderFlexibleBox::layoutColumnReverse.

Nit: this description goes in between the "Reviewed by" line and the "Test" line. Sorry about that but that's what the coding style says

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211208/d5511278/attachment.htm>

More information about the webkit-unassigned mailing list