[Webkit-unassigned] [Bug 233906] Deployment target for macOS 11+ does not follow minor version bumps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233906

--- Comment #5 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #2)

> > Source/JavaScriptCore/Configurations/DebugRelease.xcconfig:37
> > +MACOSX_DEPLOYMENT_TARGET_120000 = $(inherited);
> 
> How does this work, what is this inherited from? It seems like it ends up
> being empty, and can be removed. Also unclear to me why 11.0 and 12.0 are
> handled differently.

They inherit from the SDK default, but you're right that they can be removed -- this setting isn't overriding anything in the pbxprojs.

My hesitation with changing 11.0 is that you can currently force a macOS 11.0 deployment target by setting

    TARGET_MAC_OS_X_VERSION_MAJOR = 110000

which is long-standing functionality from https://commits.webkit.org/47162@main. AFAICT, we can't continue to support TARGET_MAC_OS_X_VERSION_MAJOR with minor-versioned deployment targets without hardcoding every known deployment target we support. But I left it in place, in case anyone depends on it for 11.0 and below. What do you think about that tradeoff? Could we stop letting TARGET_MAC_OS_X_VERSION_MAJOR influence the deployment target altogether?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211207/6439e5f5/attachment.htm>