[Webkit-unassigned] [Bug 233906] Deployment target for macOS 11+ does not follow minor version bumps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233906

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 446108
  --> https://bugs.webkit.org/attachment.cgi?id=446108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446108&action=review

> Source/JavaScriptCore/ChangeLog:8
> +				Change the deployment target for macOS 11 and above to use the default

Please use spaces in ChangeLog too (style checker said that, but it's not necessarily super visible).


The ChangeLog would benefit from mentioning that <rdar://problem/70185899> is now fixed in all versions of Xcode that we use, so you are removing the workaround while at it.

> Source/WTF/ChangeLog:8
> +				Change the deployment target for macOS 11 and above to use the default

Not entirely sure if committing will merge the explanations; could make for a terrible commit message if not. I usually only put a long explanation in WebCore ChangeLog, but not sure if that's right or necessary.

Just saying it out loud, you don't have to investigate or change this.

> Source/JavaScriptCore/Configurations/DebugRelease.xcconfig:34
>  MACOSX_DEPLOYMENT_TARGET_101400 = 10.14;

10.14 can/should be removed at this point.

> Source/JavaScriptCore/Configurations/DebugRelease.xcconfig:37
> +MACOSX_DEPLOYMENT_TARGET_120000 = $(inherited);

How does this work, what is this inherited from? It seems like it ends up being empty, and can be removed. Also unclear to me why 11.0 and 12.0 are handled differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211207/7cfe2d6a/attachment-0001.htm>