[Webkit-unassigned] [Bug 233764] Make enum values consistent in ApplicationManifest::Icon::Purpose and _WKApplicationManifestIconPurpose

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233764

--- Comment #5 from rginsberg at apple.com ---
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 445744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445744&action=review
> 
> This looks fine, but I suggest following the model of the underling WebCore
> type and use the bitwise-shift to show the mask values.
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:46
> > +    _WKApplicationManifestIconPurposeAny = 1,
> 
> We should follow the behavior of the
> WebCore::ApplicationManifest::Icon::Purpose enum:
> 
> _WKApplicationManifestIconPurposeAny =  (1 << 0),
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:47
> > +    _WKApplicationManifestIconPurposeMonochrome = 2,
> 
> _WKApplicationManifestIconPurposeMonochrome = (1 << 1),
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:48
> > +    _WKApplicationManifestIconPurposeMaskable = 4,
> 
> _WKApplicationManifestIconPurposeMaskable = (1 << 2),

Thanks! Just uploaded a patch that uses this model

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211202/55d84516/attachment.htm>