[Webkit-unassigned] [Bug 233764] Make enum values consistent in ApplicationManifest::Icon::Purpose and _WKApplicationManifestIconPurpose

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233764

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #445744|review?                     |review-
              Flags|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 445744
  --> https://bugs.webkit.org/attachment.cgi?id=445744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445744&action=review

This looks fine, but I suggest following the model of the underling WebCore type and use the bitwise-shift to show the mask values.

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:46
> +    _WKApplicationManifestIconPurposeAny = 1,

We should follow the behavior of the WebCore::ApplicationManifest::Icon::Purpose enum:

_WKApplicationManifestIconPurposeAny =  (1 << 0),

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:47
> +    _WKApplicationManifestIconPurposeMonochrome = 2,

_WKApplicationManifestIconPurposeMonochrome = (1 << 1),

> Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:48
> +    _WKApplicationManifestIconPurposeMaskable = 4,

_WKApplicationManifestIconPurposeMaskable = (1 << 2),

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211202/bd574aab/attachment-0001.htm>