[Webkit-unassigned] [Bug 233750] New: remove expandAroundIdeographs static variables

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 23:19:42 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=233750

            Bug ID: 233750
           Summary: remove expandAroundIdeographs static variables
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: heycam at apple.com
                CC: bfulgham at webkit.org, mmaxfield at apple.com,
                    simon.fraser at apple.com, zalan at apple.com
            Blocks: 233747

With OffscreenCanvas, we can call into ComplexTextController::adjustGlyphsAndAdvances, FontCascade::expansionOpportunityCountInternal, and WidthIterator::calculateAdditionalWidth from worker threads.  These all have a static variable variable with an initializer that calls FontCascade::canExpandAroundIdeographsInComplexText, and such initializers are not safe under -fno-threadsafe-statics.

canExpandAroundIdeographsInComplexText is a simple enough function in all ports (it just returns a constant bool) that it's not worth caching the result in a static.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=233747
[Bug 233747] move FontCache singleton and instance on WorkerGlobalScope to ThreadGlobalData
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211202/4a0f354c/attachment.htm>


More information about the webkit-unassigned mailing list