[Webkit-unassigned] [Bug 233725] File inputs in non-multipart form submissions show up as string values in the formdata event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233725

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 445620
  --> https://bugs.webkit.org/attachment.cgi?id=445620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445620&action=review

> Source/WebCore/ChangeLog:10
> +        filename. Before r280310, this optimizaton was unobservable, since the DOMFormData object

typo: optimizaton

> Source/WebCore/html/FileInputType.cpp:161
> +bool FileInputType::appendFormData(DOMFormData& formData, bool) const

Can we drop the boolean parameter completely now or is it still required for some reason?

> Source/WebCore/platform/network/FormData.cpp:277
> +        if (std::holds_alternative<String>(item.data))

May be nice to use WTF::switchOn() here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211202/ba62ff83/attachment.htm>