[Webkit-unassigned] [Bug 233483] check-webkit-style: regenerate localized strings when LocalizedStrings source files change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 06:45:27 PST 2021


--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to David Kilzer (:ddkilzer) from comment #3)
> My thinking was that knowledge of the changed files in the patch being
> uploaded would be needed in order to make a decision about whether this
> check needs to be done, and webkit-patch would have that (not
> check-WebKit-style).
> For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed,
> then this should be checked, but otherwise it should not (to save time).
> I guess the actual code to do the checking could be in check-webkit-style,
> and the logic about whether to run the checker could be in webkit-patch,
> though.

check-webkit-style actually owns the knowledge of the changed files, since it only operates on the blocks of code a user is changing

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211201/6b3bddff/attachment.htm>

More information about the webkit-unassigned mailing list