[Webkit-unassigned] [Bug 233694] [GTK][a11y] Add implementation of table and table cell interfaces when building with ATSPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233694

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #445554|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 445554
  --> https://bugs.webkit.org/attachment.cgi?id=445554
Patch

Other than changing a few pointer literals to “nulptr” before landing, patch LGTM.


View in context: https://bugs.webkit.org/attachment.cgi?id=445554&action=review

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1069
> +        return JSStringCreateWithCharacters(0, 0);

While changing this you could replace the first zero with nullptr:

    return JSStringCreateWithCharacters(nullptr, 0);

=]

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1078
> +        return JSStringCreateWithCharacters(0, 0);

Same here: s/0/nullptr

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1092
> +        return JSStringCreateWithCharacters(0, 0);

...and here...

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1101
> +        return JSStringCreateWithCharacters(0, 0);

...one more...

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1146
> +        return JSStringCreateWithCharacters(0, 0);

...and another...

(okay, I will stop commenting now on each of those)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211201/43fa4329/attachment-0001.htm>