[Webkit-unassigned] [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203312

--- Comment #34 from Kevin Turner <kevinturner at utexas.edu> ---
(In reply to Darin Adler from comment #32)
> Comment on attachment 436898 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436898&action=review
> 
> Unclear on how good the test coverage is for all this code. There are a lot
> of subtle things here to get right or wrong, and the tests are critical.
> 
I will look at expanding the tests included, I've been thinking through more edge cases and extreme cases to account for. 

> 
> Really confused about how CSSCalcValue uses double, and
> CalcExpressionOperation uses float.

Not sure about this incongruence either, I can't think of a reason why they shouldn't be the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210901/45ac0da2/attachment-0001.htm>