[Webkit-unassigned] [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203312

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #436786|review?                     |review+
              Flags|                            |

--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 436786
  --> https://bugs.webkit.org/attachment.cgi?id=436786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436786&action=review

Would be nice to make Web Platform Tests for these.

> Source/WebCore/ChangeLog:2
> +       Add support for pow(), sqrt() and hypot() per https://drafts.csswg.org/css-values-4/#exponent-funcs.

Missing blank line

> Source/WebCore/ChangeLog:7
> +       Test: fast/css/calc-parsing.html

Normally we write some words here to say what the change does. The spec link would be better here.

> Source/WebCore/ChangeLog:9
> + 
> +

Extra. blank line.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:154
> +            // The type of a min(), max(), clamp() or hypot() expression is the result of adding the types of its comma-separated calculations
> +            return CalculationCategory::Other;

I can't tell if the line you copied above with the comment represents a TODO or correct behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210830/a4b10cec/attachment.htm>