[Webkit-unassigned] [Bug 229542] [CSS Cascade Layers] Initial support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229542

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #436491|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 436491
  --> https://bugs.webkit.org/attachment.cgi?id=436491
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436491&action=review

> Source/WebCore/css/StyleRule.h:265
> +    Variant<CascadeLayerName, Vector<CascadeLayerName>> m_nameVariant;

Is this preferable to just always using a Vector<>? Or is a name list with one item different from a simple name?

> Source/WebCore/css/StyleRuleType.h:40
>      Namespace = 10,

What happened to 9? Why do we number these from here on?

> Source/WebCore/css/parser/CSSAtRuleID.h:51
> +    CSSAtRuleLayer = 13,

Not sure why we need exploit values here?

> Source/WebCore/style/RuleSet.cpp:510
> +            // FIXME: This is not correct when adding a sublayer to an already registered layer after it has gained siblings.

Reference a bug url?

> Source/WebCore/style/RuleSet.h:196
> +    // FIXME: These should be in stack.

in a stack? on the stack?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210827/ceb7515a/attachment-0001.htm>