[Webkit-unassigned] [Bug 229415] AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229415

--- Comment #11 from Tyler Wilcock <tyler_w at apple.com> ---
(In reply to chris fleizach from comment #8)
> Comment on attachment 436303 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436303&action=review
> 
> > LayoutTests/ChangeLog:13
> > +        * accessibility/mac/search-predicate-for-adhoc-radio-groups-expected.txt: Added.
> 
> is this a Mac specific test? I don't think the uiSearch exists for any
> platform
> 
> should we move just into the Mac directory?

Sorry, the Changelog is stale — Andres suggested we also test this on iOS, so I moved it out of the Mac folder. There is this function in the AccessibilityUIElementIOS class:

RefPtr<AccessibilityUIElement> AccessibilityUIElement::uiElementForSearchPredicate(JSContextRef context, AccessibilityUIElement *startElement, bool isDirectionNext, JSValueRef searchKey, JSStringRef searchText, bool visibleOnly, bool immediateDescendantsOnly)
{
    NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly);
    ...
}

However, I just realized that this search is hardcoded to return 5 matching elements, vs. the same function in AccessibilityUIElementMac which returns only 1 matching element, so this won't work without parameterizing that value...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210824/da532c8f/attachment.htm>