[Webkit-unassigned] [Bug 229416] [GTK] Add webkit_web_view_try_close stay event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 23:39:42 PDT 2021


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 436225
  --> https://bugs.webkit.org/attachment.cgi?id=436225

View in context: https://bugs.webkit.org/attachment.cgi?id=436225&action=review

>> Source/WebKit/UIProcess/API/APIUIClient.h:89
>> +    virtual void stayOnPage(WebKit::WebPageProxy*) { }
> Technically we need an owner to approve this line of the diff, but that shouldn't be a problem since it's only one line and obviously OK.

This name sounds like the user needs to take an action, but it's just a notification. I would use something like didNotClose, didCancelClose or something like that.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:176
> +    STAY_ON_PAGE,

And same for the glib api signal.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1685
> +     * Emitted when try closing a #WebKitWebView is aborted.

We should document here why close can fail. And you also need to update the webkit_web_view_try_close() doc  that says that nothing happens when user cancels the close.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2530
> +    g_signal_emit(webView, signals[STAY_ON_PAGE], 0, NULL);

NULL -> nullptr

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210824/66ad2473/attachment.htm>

More information about the webkit-unassigned mailing list